[Merge] ~morphis/aethercast/+git/aethercast:feature/snap-support into aethercast:master

[Thomas Voß]

Review: Needs Fixing

Looking a lot better, thanks. Two remaining niggles inline.

Diff comments:

> diff --git a/src/ac/config.h b/src/ac/config.h
> new file mode 100644
> index 0000000..5b0eff2
> --- /dev/null
> +++ b/src/ac/config.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (C) 2015 Canonical, Ltd.
> + *
> + * This program is free software: you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 3, as published
> + * by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranties of
> + * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
> + * PURPOSE.  See the GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program.  If not, see <http://www.gnu.org/licenses/>.
> + *
> + */
> +
> +#ifndef AC_CONFIG_H_
> +#define AC_CONFIG_H_
> +
> +#include <boost/filesystem/path.hpp>
> +
> +namespace ac {
> +class SystemConfiguration {
> + public:
> +  static SystemConfiguration& instance();

Please return a const reference here.

> +
> +  virtual ~SystemConfiguration() = default;

Please delete copy/move ctor/assignment operators.

> +
> +  virtual boost::filesystem::path RuntimePath() const = 0;
> +  virtual boost::filesystem::path StateDirPath() const = 0;
> +
> + protected:
> +  SystemConfiguration() = default;
> +};
> +}
> +
> +#endif


-- 
https://code.launchpad.net/~morphis/aethercast/+git/aethercast/+merge/315435
Your team Ubuntu Phablet Team is subscribed to branch aethercast:master.