[Merge] lp:~tribaal/livecd-rootfs/add-vagrant-user into lp:livecd-rootfs

[Francis Ginther]

Review: Needs Information

What restricts this change to artful? My understanding is that we're only introducing the vagrant:vagrant setup for artful and newer releases.

There is a comment on line 105 of this file:
# Vagrant needs a base user. We either inject the well-known SSH key
# or use password authentication. Both are ugly. So we'll use a password
# and make it random. This obviously is insecure...but at least its
# better than the alternatives.

This is no longer true now that we are adding the well-known SSH key.



Diff comments:

> === modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
> --- live-build/ubuntu-cpc/hooks/042-vagrant.binary	2017-06-14 16:25:11 +0000
> +++ live-build/ubuntu-cpc/hooks/042-vagrant.binary	2017-08-25 15:03:15 +0000
> @@ -139,10 +161,9 @@
>  include_vagrantfile = File.expand_path("../include/_Vagrantfile", __FILE__)
>  load include_vagrantfile if File.exist?(include_vagrantfile)
>  
> +## We also have an "ubuntu" user with pass "${ubuntu_user_pass}"

Is this comment still meaningful in the Vagrantfile?

>  Vagrant.configure("2") do |config|
>    config.vm.base_mac = "${macaddr}"
> -  config.ssh.username = "ubuntu"
> -  config.ssh.password = "${ubuntu_user_pass}"
>  
>    config.vm.provider "virtualbox" do |vb|
>       vb.customize [ "modifyvm", :id, "--uart1", "0x3F8", "4" ]


-- 
https://code.launchpad.net/~tribaal/livecd-rootfs/add-vagrant-user/+merge/329598
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~tribaal/livecd-rootfs/add-vagrant-user into lp:livecd-rootfs.