[Merge] lp:~fboucault/webbrowser-app/address_bar_populate_selected_suggestion into lp:webbrowser-app/staging

Florian Boucault florian.boucault at canonical.com
Tue Apr 4 09:27:44 UTC 2017


Florian Boucault has proposed merging lp:~fboucault/webbrowser-app/address_bar_populate_selected_suggestion into lp:webbrowser-app/staging with lp:~osomon/webbrowser-app/qmltests as a prerequisite.

Commit message:
Address bar suggestions:
* When highlighting a suggestion, copy it to the address bar.
* Preserve search suggestions when going up/down
* Add static search suggestion as first element

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1677258 in webbrowser-app (Ubuntu): "[browser] keyboard navigation from url search should populate field"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1677258

For more details, see:
https://code.launchpad.net/~fboucault/webbrowser-app/address_bar_populate_selected_suggestion/+merge/321828

Address bar suggestions:
* When highlighting a suggestion, copy it to the address bar.
* Preserve search suggestions when going up/down
* Add static search suggestion as first element
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~fboucault/webbrowser-app/address_bar_populate_selected_suggestion into lp:webbrowser-app/staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 16997 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170404/58707088/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list