[Merge] lp:~artmello/mediaplayer-app/mediaplayer-app-changes_snapcraft into lp:mediaplayer-app

[Jim Hodapp]

Review: Needs Information



Diff comments:

> 
> === modified file 'snapcraft.yaml'
> --- snapcraft.yaml	2016-09-27 20:16:04 +0000
> +++ snapcraft.yaml	2016-09-27 20:16:04 +0000
> @@ -5,11 +5,12 @@
>    A QML media player that can play audio/video sources.
>    Please find the source at:
>    https://code.launchpad.net/mediaplayer-app
> +grade: stable
>  confinement: strict
>  
>  apps:
>    mediaplayer-app:
> -    command: usr/bin/mediaplayer-app
> +    command: desktop-launch mediaplayer-app

I assume that desktop-launch is fully taking the place of mediaplayer.wrapper? Were you able to test that it can find the qtubuntu-media library or the default GStreamer based one depending on which is installed located at:

export QT_PLUGIN_PATH=$SNAP/usr/lib/$ARCH/qt5/plugins/media/

>      plugs: [mpris]
>  
>  parts:
> @@ -63,8 +64,14 @@
>      snap:
>        - $unwanted
>  
> +    after: [desktop-qt5]
> +
>    environment:
> -    plugin: copy
> -    files:
> -      mediaplayer-app.wrapper: bin/mediaplayer-app
> +    source: .
> +    plugin: dump
> +    organize:
>        debian/copyright: usr/share/doc/mediaplayer-app/copyright
> +    stage:
> +       - usr/share/doc/mediaplayer-app/copyright

If you stage this file, won't it automatically be placed into the snap package as well?

> +    snap:
> +       - usr/share/doc/mediaplayer-app/copyright


-- 
https://code.launchpad.net/~artmello/mediaplayer-app/mediaplayer-app-changes_snapcraft/+merge/306942
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/mediaplayer-app/snap-it-up.