[Merge] lp:~nick-dedekind/qtubuntu/1623861.window-focus into lp:qtubuntu

Nick Dedekind nick.dedekind at canonical.com
Wed Sep 28 08:09:46 UTC 2016


> Looks good. just one minor thing:
> 
> """
> // Mir may have sent a pair of focus lost/gained events, so we need to "peek"
> into the queue
> // so that we don't deactivate windows prematurely.
> """
> 
> Please move that comment from UbuntuInput to UbuntuWindow as well (instead of
> just deleting it). This mPendingFocusGainedEvents scheme is non-obvious and
> thus deserves a comment.

Done

> 
> Your commit message is also too vague. What you did was making the focus-
> change optimization logic support multiple windows (by moving it to
> UbuntuWindow and thus making it per-window).

Done
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/1623861.window-focus/+merge/306318
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list