[Merge] lp:~renatofilho/mediaplayer-app/add-unittest into lp:mediaplayer-app

Jim Hodapp jim.hodapp at canonical.com
Tue Sep 27 12:23:13 UTC 2016


Review: Needs Fixing code

One minor change

Diff comments:

> 
> === modified file 'debian/control'
> --- debian/control	2016-09-21 15:27:02 +0000
> +++ debian/control	2016-09-26 23:13:09 +0000
> @@ -12,6 +12,14 @@
>                 qtbase5-dev,
>                 qtdeclarative5-dev,
>                 qtmultimedia5-dev,
> +# used by unittest

Please change to: "The following deps are all needed for unit tests"

> +               qml-module-qtmultimedia | qml-module-qtmultimedia-gles,
> +               qml-module-qttest [amd64 arm64 armhf i386],
> +               qml-module-qtquick-xmllistmodel [amd64 arm64 armhf i386],
> +               qml-module-ubuntu-test [amd64 arm64 armhf i386],
> +               qtdeclarative5-dev-tools [amd64 arm64 armhf i386],
> +               xvfb [amd64 arm64 armhf i386],
> +               gstreamer1.0-plugins-base [amd64 arm64 armhf i386],
>  Standards-Version: 3.9.5
>  # If you don't have commit rights to lp:mediaplayer-app but need to upload
>  # packaging changes, just go ahead.  The developers will notice and sync


-- 
https://code.launchpad.net/~renatofilho/mediaplayer-app/add-unittest/+merge/306784
Your team Ubuntu Phablet Team is subscribed to branch lp:mediaplayer-app.



More information about the Ubuntu-reviews mailing list