[Merge] lp:~phablet-team/ubuntu-system-settings/path-fixes into lp:ubuntu-system-settings

Jonas G. Drange jonas.drange at canonical.com
Fri Sep 23 12:33:54 UTC 2016


Jonas G. Drange has proposed merging lp:~phablet-team/ubuntu-system-settings/path-fixes into lp:ubuntu-system-settings.

Commit message:
uses XDG_DATA_DIRS where applicable to enable USS to find files and folders on snappy-based systems

Requested reviews:
  Ken VanDine (ken-vandine)
  system-apps-ci-bot (system-apps-ci-bot): continuous-integration

For more details, see:
https://code.launchpad.net/~phablet-team/ubuntu-system-settings/path-fixes/+merge/306115

Rewrites code that reference hard coded paths (e.g. /usr/share/foo) to use QStandardPaths. Some paths, e.g. to /etc, are still hard coded, but I've prepended $SNAP, which should be empty ("") on traditional non-snappy systems.

Packaging changes are deps that were missing.

Note: I have left the background panel mostly alone, due to [1]. I've also left the Updates panel alone—it will never be expected to work as it is now, on snappy.

[1] https://code.launchpad.net/~mterry/ubuntu-system-settings/default-wallpaper/+merge/297632
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-system-settings/path-fixes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 22080 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160923/90d1ddb5/attachment.diff>


More information about the Ubuntu-reviews mailing list