[Merge] lp:~ahayzen/webbrowser-app/fix-calendar-ua-override-001 into lp:webbrowser-app

Andrew Hayzen andrew.hayzen at canonical.com
Wed Sep 21 16:29:42 UTC 2016


Andrew Hayzen has proposed merging lp:~ahayzen/webbrowser-app/fix-calendar-ua-override-001 into lp:webbrowser-app.

Commit message:
* Modify calendar ua-override to allow anything before google.com (allowing calendar.google.com)

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~ahayzen/webbrowser-app/fix-calendar-ua-override-001/+merge/306360

* Modify calendar ua-override to allow anything before google.com (allowing calendar.google.com)

Before the override had (www\.)? before the google.com which meant that it would capture www.google.com/calendar and google.com/calendar but not calendar.google.com/calendar. Now it allows anything to the before the .google.com/calendar. This likely broke as google changed the redirect at their end not to match the previous regex.

TESTING:
Please test all of these work:
calendar.google.com
google.com/calendar
www.google.com/calendar
calendar.google.com/calendar
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/webbrowser-app/fix-calendar-ua-override-001 into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1135 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160921/10c0369a/attachment.diff>


More information about the Ubuntu-reviews mailing list