[Merge] lp:~dandrader/qtubuntu/loggingFixes into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Mon Sep 12 13:56:49 UTC 2016


Review: Needs Information

+    case mir_event_type_input_device_state:
+        return "mir_event_type_input_device_state";
     default:
return "invalid";

this is why I try to avoid "default" for these cases - entries added to the Mir enum aren't noticed by us. Does it compile if you remove the "default"?

Looks ok otherwise
-- 
https://code.launchpad.net/~dandrader/qtubuntu/loggingFixes/+merge/305374
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list