[Merge] lp:~phablet-team/media-hub/snap-packaging into lp:media-hub

Simon Fels simon.busch at canonical.com
Wed Sep 7 13:25:30 UTC 2016


Review: Approve

Two minor notes.

Diff comments:

> === added file 'snapcraft.yaml'
> --- snapcraft.yaml	1970-01-01 00:00:00 +0000
> +++ snapcraft.yaml	2016-09-06 19:26:40 +0000
> @@ -0,0 +1,53 @@
> +name: media-hub
> +version: 4.6.0

Missing a revision. Use 4.6.0-1 to by in sync with our guidelines.

> +summary: Server and client sides of media-hub
> +description: |
> +  Media Hub is a simple and lightweight service for media playback using
> +  DBus. Please find the source code at:
> +  https://code.launchpad.net/media-hub
> +confinement: strict
> +
> +apps:
> +  service:
> +    command: usr/bin/media-hub-server
> +    slots: [mpris]
> +    plugs: [pulseaudio]
> +
> +parts:
> +  service:
> +    plugin: cmake
> +    source: .
> +
> +    build-packages:
> +      - dbus-test-runner
> +      - debhelper
> +      - dh-apparmor
> +      - doxygen
> +      - google-mock
> +      - graphviz
> +      - gstreamer1.0-plugins-good
> +      - libboost-dev
> +      - libboost-filesystem-dev
> +      - libboost-log-dev
> +      - libboost-program-options-dev
> +      - libboost-system-dev
> +      - libdbus-1-dev
> +      - libdbus-cpp-dev
> +      - libgoogle-glog-dev
> +      - libgstreamer1.0-dev
> +      - libgstreamer-plugins-base1.0-dev
> +      - libhybris-dev
> +      - libprocess-cpp-dev
> +      - libproperties-cpp-dev
> +      - libpulse-dev
> +      - libtelepathy-qt5-dev
> +      - lsb-release
> +      - pkg-config
> +      - qtbase5-dev
> +
> +    stage-packages:
> +      - gstreamer1.0-fluendo-mp3

Can you add a comment that shipping this one is ok?

> +
> +    configflags:
> +      - -DCMAKE_INSTALL_PREFIX:PATH=/usr
> +      - -DCMAKE_LIBRARY_PATH=/usr/lib


-- 
https://code.launchpad.net/~phablet-team/media-hub/snap-packaging/+merge/303825
Your team Ubuntu Phablet Team is subscribed to branch lp:media-hub.



More information about the Ubuntu-reviews mailing list