[Merge] lp:~osomon/webbrowser-app/snap into lp:webbrowser-app

[Alexandre Abreu]

Review: Approve

looks ok (and works), I added a small comment,

Diff comments:

> 
> === added file 'snapcraft.yaml'
> --- snapcraft.yaml	1970-01-01 00:00:00 +0000
> +++ snapcraft.yaml	2016-09-02 15:02:41 +0000
> @@ -0,0 +1,54 @@
> +name: webbrowser-app
> +version: 0.23+16.10.20160825-0ubuntu1

can the version be not hardcoded?

> +summary: Ubuntu web browser
> +description: A lightweight web browser tailored for Ubuntu, based on the Oxide browser engine and using the Ubuntu UI components.
> +confinement: strict
> +
> +apps:
> +  webbrowser-app:
> +    command: desktop-launch launcher webbrowser-app
> +    plugs: [browser-sandbox, network-bind, unity7, opengl, network, pulseaudio]
> +
> +plugs:
> +  browser-sandbox:
> +    interface: browser-support
> +    allow-sandbox: true
> +
> +parts:
> +  webbrowser-app:
> +    plugin: cmake
> +    source: .
> +    build-packages:
> +      - libapparmor-dev
> +      - libevdev-dev
> +      - libudev-dev
> +      - lsb-release
> +      - pkg-config
> +      - qt5-qmake
> +      - qtbase5-dev
> +      - qtbase5-dev-tools
> +      - qtbase5-private-dev
> +      - qtdeclarative5-dev
> +      - qttools5-dev-tools
> +      - xvfb
> +    stage-packages:
> +      - fonts-liberation
> +      - liboxideqt-qmlplugin
> +      - libqt5sql5-sqlite
> +      - qml-module-qt-labs-folderlistmodel
> +      - qml-module-qt-labs-settings
> +      - qml-module-qtquick2
> +      - qml-module-qtquick-layouts
> +      - qml-module-qtquick-window2
> +      - qml-module-ubuntu-components
> +      - qml-module-ubuntu-thumbnailer0.1
> +      - qtdeclarative5-ubuntu-content1
> +      - qtdeclarative5-ubuntu-download-manager0.1
> +      - qtdeclarative5-unity-action-plugin
> +    after: [desktop/qt5]
> +
> +  launcher:
> +    plugin: dump
> +    source: snap
> +    organize:
> +      launcher: bin/launcher


-- 
https://code.launchpad.net/~osomon/webbrowser-app/snap/+merge/304794
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.