[Merge] lp:~phablet-team/history-service/improve_information_events into lp:history-service/staging

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Looks good, just has one obsolete comment to remove.

Diff comments:

> 
> === modified file 'daemon/historydaemon.h'
> --- daemon/historydaemon.h	2016-10-13 18:21:00 +0000
> +++ daemon/historydaemon.h	2016-10-13 18:21:00 +0000
> @@ -78,7 +78,7 @@
>      void updateRoomProperties(const QString &accountId, const QString &threadId, History::EventType type, const QVariantMap &properties, const QStringList &invalidated);
>  
>      // FIXME: this is a hack. we need proper information event support.

I think this comment is obsolete.

> -    void writeInformationEvent(const QVariantMap &thread, const QString &text);
> +    void writeInformationEvent(const QVariantMap &thread, History::InformationType type, const QString &subject = QString(), const QString &text = QString());
>  
>      void writeRoomChangesInformationEvents(const QVariantMap &thread, const QVariantMap &interfaceProperties);
>      void writeRolesInformationEvents(const QVariantMap &thread, const Tp::ChannelPtr &channel, const RolesMap &rolesMap);


-- 
https://code.launchpad.net/~phablet-team/history-service/improve_information_events/+merge/308429
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/history-service/notify-group-changes-in-conversation.