[Merge] lp:~phablet-team/history-service/notify-group-changes-in-conversation into lp:history-service/staging

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Just one problem to fix, looks good otherwise.

Diff comments:

> === modified file 'daemon/historydaemon.cpp'
> --- daemon/historydaemon.cpp	2016-10-13 18:20:38 +0000
> +++ daemon/historydaemon.cpp	2016-10-13 18:20:38 +0000
> @@ -54,6 +55,19 @@
>      return argument;
>  }
>  
> +bool foundAsMemberInThread(const Tp::ContactPtr& contact, QVariantMap thread)
> +{
> +    Q_FOREACH (QVariant participant, thread[History::FieldParticipants].toList()) {
> +        // found if same identifier and as member into thread info
> +        if (contact->id() == participant.toMap()[History::FieldIdentifier].toString() &&

For protocols that are phone number based, we need to compare phone numbers instead of just string comparing.
You can use History::Utils::compareIds(accoundId, id1, id2) and it will do the right thing.

> +                participant.toMap()[History::FieldParticipantState].toUInt() == History::ParticipantStateRegular)
> +        {
> +            return true;
> +        }
> +    }
> +    return false;
> +}
> +
>  HistoryDaemon::HistoryDaemon(QObject *parent)
>      : QObject(parent), mCallObserver(this), mTextObserver(this)
>  {


-- 
https://code.launchpad.net/~phablet-team/history-service/notify-group-changes-in-conversation/+merge/308428
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/history-service/include-message-when-group-cancelled.