[Merge] lp:~phablet-team/messaging-app/add-participant-info-screen into lp:messaging-app/staging

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Just one remark, looks good otherwise.

Diff comments:

> === modified file 'src/qml/GroupChatInfoPage.qml'
> --- src/qml/GroupChatInfoPage.qml	2016-10-13 18:15:37 +0000
> +++ src/qml/GroupChatInfoPage.qml	2016-10-13 18:15:38 +0000
> @@ -374,8 +404,24 @@
>                          }
>                          return (chatEntry.groupFlags & ChatEntry.ChannelGroupFlagCanRemove)
>                      }
> +                    function removeFromGroup() {
> +                        leadingActions.actions[0].trigger()

This approach is not good: in case the design changes and we change the action order, this code will silently break.

Can you make this functions be the way to remove from group and have the action trigger to call it?

> +                    }
>                      participant: modelData
>                      leadingActions: canRemove() ? participantLeadingActions : undefined
> +                    onClicked: {
> +                        if (openProfileButton.visible) {
> +                            mainStack.addPageToCurrentColumn(groupChatInfoPage, Qt.resolvedUrl("ParticipantInfoPage.qml"), {"delegate": participantDelegate, "chatEntry": chatEntry, "chatRoom": chatRoom})
> +                        }
> +                    }
> +                    Icon {
> +                       id: openProfileButton
> +                       anchors.right: parent.right
> +                       anchors.rightMargin: units.gu(1)
> +                       anchors.verticalCenter: parent.verticalCenter
> +                       height: units.gu(2)
> +                       name: "go-next"
> +                    }
>                  }
>              }
>              Item {


-- 
https://code.launchpad.net/~phablet-team/messaging-app/add-participant-info-screen/+merge/308424
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/messaging-app/end-group-info-event.