[Merge] lp:~osomon/webbrowser-app/fix-1632620-sound-yakkety into lp:webbrowser-app
Jamie Strandboge
jamie at ubuntu.com
Thu Oct 13 20:22:47 UTC 2016
Review: Approve
+1 provided you verify the '$$' works as intended.
Diff comments:
> === modified file 'debian/rules'
> --- debian/rules 2016-09-27 16:19:42 +0000
> +++ debian/rules 2016-10-13 20:08:29 +0000
> @@ -18,7 +18,8 @@
> sed 's#/run/shm/\.org\.chromium\.Chromium\.\*#/{dev,run}/shm/.org.chromium.Chromium.*#g' | \
> egrep -v 'deny /run/udev/data/\*\* r,' | \
> sed 's#^}$$#\n /sys/class/ r,\n /sys/class/input/ r,\n /run/udev/data/** r,\n}#g' | \
> - egrep -v '^\s*deny /dev/ r,\s*$$' \
> + egrep -v '^\s*deny /dev/ r,\s*$$' | \
> + sed 's#^\(\s*\)deny\(\s\+/{run,dev}/shm/pulse-shm\*\s\+w,\).*$$#\1owner\2#g' \
I guess you are using '$$' instead of '$' due to this being debian/rules.
ACK to changing this:
deny /{run,dev}/shm/pulse-shm* w, # deny unless we have to have it
to:
owner /{run,dev}/shm/pulse-shm* w,
> > ./debian/usr.bin.webbrowser-app
> ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
> apparmor_parser -QTK ./debian/usr.bin.webbrowser-app
--
https://code.launchpad.net/~osomon/webbrowser-app/fix-1632620-sound-yakkety/+merge/308454
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/fix-1632620-sound-yakkety into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list