[Merge] lp:~gerboland/qtubuntu/add--more-surface-type-support into lp:qtubuntu
Lukáš Tinkl
lukas.tinkl at canonical.com
Thu Oct 13 11:39:33 UTC 2016
Review: Needs Information
Just a curious question inline :)
Diff comments:
>
> === modified file 'src/ubuntumirclient/window.cpp'
> --- src/ubuntumirclient/window.cpp 2016-10-13 11:33:11 +0000
> +++ src/ubuntumirclient/window.cpp 2016-10-13 11:33:11 +0000
> @@ -140,6 +158,27 @@
> }
> }
>
> +MirSurfaceType qtWindowTypeToMirSurfaceType(Qt::WindowType type)
> +{
> + switch (type & Qt::WindowType_Mask) {
> + case Qt::Dialog:
> + return mir_surface_type_dialog;
> + case Qt::Sheet:
> + case Qt::Drawer:
> + return mir_surface_type_utility;
> + case Qt::Popup:
> + case Qt::Tool:
Wouldn't Qt:Tool better be represented by mir_surface_type_satellite?
> + return mir_surface_type_menu;
> + case Qt::ToolTip:
> + return mir_surface_type_tip;
> + case Qt::SplashScreen:
> + return mir_surface_type_freestyle;
> + case Qt::Window:
> + default:
> + return mir_surface_type_normal;
> + }
> +}
> +
> WId makeId()
> {
> static int id = 1;
--
https://code.launchpad.net/~gerboland/qtubuntu/add--more-surface-type-support/+merge/308367
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
More information about the Ubuntu-reviews
mailing list