[Merge] lp:~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position into lp:webbrowser-app

[Andrew Hayzen]

Andrew Hayzen has proposed merging lp:~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position into lp:webbrowser-app with lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap as a prerequisite.

Commit message:
* Change onXChanged to move to the current position of X and not just +/- 1
* Improve TabsModel::move to be able to handle gaps between the from and to

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1630211 in webbrowser-app (Ubuntu): "Moving a tab quickly when there are many tabs open, sometimes causes tab to left in a incorrect position"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1630211

For more details, see:
https://code.launchpad.net/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position/+merge/307709

* Change onXChanged to move to the current position of X and not just +/- 1
* Improve TabsModel::move to be able to handle gaps between the from and to

TESTING:
- Open *many* tabs and quickly drag the first to the last position, with this branch it should always end up in the right place
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2534 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20161005/f2b0fa7a/attachment.diff>