[Merge] lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Tue Oct 4 11:24:06 UTC 2016
> In addition I've noticed another existing bug, the way the tab move() is done
> is on the onXChanged. It only ever moves the tab +/- 1 to the left/right. This
> appears fine on a small number of tabs, but if you have *many* tabs open and
> quickly move the tab from one end to the other. The animation on X occurs, but
> it doesn't cause every X value to be 'hit' as it needs to reach the target
> within the duration. Which then means that some of the moves are missed,
> leaving the tab in the middle and not all the way across.
>
> This seems like a slightly invasive change, should I report a bug and fix it
> in another branch?
Yes, please file a bug report and address it in a separate branch, based off this one.
--
https://code.launchpad.net/~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap/+merge/307415
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list