[Merge] lp:~michael-sheldon/ubuntu-download-manager/snap into lp:ubuntu-download-manager

Lukáš Tinkl lukas.tinkl at canonical.com
Tue Nov 29 15:42:28 UTC 2016


Review: Needs Fixing

+ if (QDir::homePath().contains(QString("snap%1ubuntu-download-manager").arg(QDir::separator()))) {

The usage of QDir::separator() is really discouraged, you could as well write a much simpler version:

+ if (QDir::homePath().contains(QStringLiteral("snap/ubuntu-download-manager"))) {
-- 
https://code.launchpad.net/~michael-sheldon/ubuntu-download-manager/snap/+merge/311611
Your team Ubuntu Phablet Team is subscribed to branch lp:ubuntu-download-manager.



More information about the Ubuntu-reviews mailing list