[Merge] ~vicamo/avila-private/+git/platform_frameworks_av:bug-1619107/media-service-for-32-bit-codecs into ~avila-private-team/avila-private/+git/platform_frameworks_av:ubuntu
Alfonso Sanchez-Beato
alfonso.sanchez-beato at canonical.com
Mon Nov 28 09:27:48 UTC 2016
Diff comments:
> diff --git a/media/libstagefright/Android.mk b/media/libstagefright/Android.mk
> index dc95b8a..67bfbe0 100644
> --- a/media/libstagefright/Android.mk
> +++ b/media/libstagefright/Android.mk
> @@ -15,6 +15,12 @@ ifeq ($(strip $(MTK_VIDEO_VP8ENC_SUPPORT)),yes)
> LOCAL_CFLAGS += -DMTK_VIDEO_VP8ENC_SUPPORT
> endif
>
> +ifdef TARGET_2ND_ARCH
> +ifneq ($(filter-out $(TARGET_2ND_ARCH),$(BOARD_UBUNTU_ARCH)),)
Alright, then please add a comment with all this information, and also mention that it works because BOARD_UBUNTU_ARCH is not defined for 32 bits versions of Ubuntu Touch. Or, maybe we should revert to using BOARD_UBUNTU_PREFER_32_BIT instead of BOARD_UBUNTU_ARCH again?
> +LOCAL_CFLAGS += -DWITH_MEDIA_PLAYER_SERVICE
> +endif
> +endif
> +
> LOCAL_SRC_FILES:= \
> ACodec.cpp \
> AACExtractor.cpp \
--
https://code.launchpad.net/~vicamo/avila-private/+git/platform_frameworks_av/+merge/308820
Your team Ubuntu Phablet Team is requested to review the proposed merge of ~vicamo/avila-private/+git/platform_frameworks_av:bug-1619107/media-service-for-32-bit-codecs into ~avila-private-team/avila-private/+git/platform_frameworks_av:ubuntu.
More information about the Ubuntu-reviews
mailing list