[Merge] lp:~ahayzen/webbrowser-app/dnd-tabs-001 into lp:webbrowser-app/staging
Olivier Tilloy
olivier.tilloy at canonical.com
Fri Nov 18 13:01:49 UTC 2016
Can DragHelper be made a QObject, instead of a QQuickItem? Can its constructor use a member initializer list?
In Reparenter::createObject(), when setting initial properties you should probably use QQmlProperty::write(…) (https://doc.qt.io/qt-5/qqmlproperty.html#write-1), and it would probably be better to use QQmlComponent::beginCreate() and QQmlComponent::completeCreate().
--
https://code.launchpad.net/~ahayzen/webbrowser-app/dnd-tabs-001/+merge/308507
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app/staging.
More information about the Ubuntu-reviews
mailing list