[Merge] lp:~phablet-team/messaging-app/broadcast_messages_icons into lp:messaging-app/staging

Tiago Salem Herrmann tiago.herrmann at canonical.com
Mon Nov 7 18:50:40 UTC 2016


Review: Needs Fixing

just a small remark.
looks good otherwise.

Diff comments:

> 
> === modified file 'src/qml/Messages.qml'
> --- src/qml/Messages.qml	2016-11-04 18:24:21 +0000
> +++ src/qml/Messages.qml	2016-11-07 17:45:14 +0000
> @@ -44,7 +44,7 @@
>          if (chatEntry.active) {
>              return chatEntry.participants
>          } else if (threads.length > 0) {
> -            return threadInformation.participants
> +            return threadInformation.participantsgback

there is a typo here

>          }
>          return []
>      }


-- 
https://code.launchpad.net/~phablet-team/messaging-app/broadcast_messages_icons/+merge/310214
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-app/staging.



More information about the Ubuntu-reviews mailing list