[Merge] lp:~phablet-team/messaging-framework/members-update-fix into lp:messaging-framework

Roberto Mier Escandón  roberto.escandon at canonical.com
Mon May 30 17:01:29 UTC 2016


Roberto Mier Escandón  has proposed merging lp:~phablet-team/messaging-framework/members-update-fix into lp:messaging-framework with lp:~phablet-team/messaging-framework/try-rejoin-group-invitation-before-accept as a prerequisite.

Commit message:
update members method in textchannel using isolated methods for adding and removing participants. Though this involves come across same array twice, code is tested and quite maintainable this way

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~phablet-team/messaging-framework/members-update-fix/+merge/296058

update members method in textchannel using isolated methods for adding and removing participants. Though this involves come across same array twice, code is tested and quite maintainable this way
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/messaging-framework/members-update-fix into lp:messaging-framework.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 11790 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160530/c7ac986f/attachment.diff>


More information about the Ubuntu-reviews mailing list