[Merge] lp:~mterry/ubuntu-keyboard/report-max-height into lp:ubuntu-keyboard
Michael Terry
michael.terry at canonical.com
Fri May 13 02:36:34 UTC 2016
Michael Terry has proposed merging lp:~mterry/ubuntu-keyboard/report-max-height into lp:ubuntu-keyboard.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1578693 in qtmir (Ubuntu): "Would be useful to expose maximum OSK height"
https://bugs.launchpad.net/ubuntu/+source/qtmir/+bug/1578693
For more details, see:
https://code.launchpad.net/~mterry/ubuntu-keyboard/report-max-height/+merge/294585
Here's my first pass at reporting maximum keyboard height, for use by upper layers.
Unfortunately, it doesn't work. :( So I'm looking for advice.
In Keyboard.qml, fullScreenItem.height seems to only match the screen height when visible. Despite d->view->setGeometry, I guess Qml knows that when not visible, the height of the root item is 0.
Is there an obvious way to size the qml correctly even when not visible? (Or should I just save the ratio from Qml and have the cpp calculate it from screen size?)
This will need lp:~mterry/qtmir/report-osk-max-height to match.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/ubuntu-keyboard/report-max-height into lp:ubuntu-keyboard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3015 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160513/cb82fcc5/attachment.diff>
More information about the Ubuntu-reviews
mailing list