[Merge] lp:~abreu-alexandre/webbrowser-app/fix-application-name-setup into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Tue May 10 14:22:25 UTC 2016


> In the implementation of BrowserApplication::initialize(), there doesn’t seem
> to be a good reason for moving the calls to
> QCoreApplication::setApplicationName() and
> QCoreApplication::setOrganizationDomain(), can you revert that change? Because
> of that change a comment ("Ensure that application-specific data is written
> where it ought to.") is out of context.

yes, a leftover, thank you done,

-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/fix-application-name-setup/+merge/293658
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list