[Merge] lp:~phablet-team/messaging-framework/notify-group-title-changed-adapt into lp:messaging-framework

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Just one change.

Diff comments:

> 
> === modified file 'include/messaging/group_manager.h'
> --- include/messaging/group_manager.h	2016-04-25 16:05:49 +0000
> +++ include/messaging/group_manager.h	2016-05-05 12:55:13 +0000
> @@ -77,6 +81,7 @@
>      void announce_group_created(const std::string& id);
>      void announce_group_cancelled();
>      void announce_group_quit();
> +    void announce_group_title_changed(const std::string& new_title);

Maybe we should have a signature more like this:
void announce_group_title_changed(const std::string &new_title,
                                  const User actor = User{},
                                  const std::chrono::system_clock::time_point = system_clock::now())

This way the API will already cover services that inform who has changed the group title and when.

This will require implementing one extra telepathy interface: Subject2, but we can add it in a separate MR.

>      void announce_members_updated(const Users& members);
>  
>      /// @cond


-- 
https://code.launchpad.net/~phablet-team/messaging-framework/notify-group-title-changed-adapt/+merge/293603
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/messaging-framework/leave-and-dissolve-session-adapt.