[Merge] lp:~toykeeper/phablet-tools/phablet-network-no-nm into lp:phablet-tools

Robert Bruce Park robert.park at canonical.com
Tue May 3 20:29:40 UTC 2016


Review: Needs Fixing

Minor nitpick.

Diff comments:

> === modified file 'phablet-network'
> --- phablet-network	2015-02-10 14:50:47 +0000
> +++ phablet-network	2015-03-03 09:25:01 +0000
> @@ -27,6 +27,7 @@
>  usage: $0 [OPTIONS]
>  
>  Copies ACTIVE network manager connection into device
> +(or uses NM-format wifi config from $DEFAULT_NETWORK_FILE)

You need to escape the $ here, as bash will interpret the variable, which isn't set until later, and just "... config from )" will be printed.

>  
>  OPTIONS:
>    -h	Show this message


-- 
https://code.launchpad.net/~toykeeper/phablet-tools/phablet-network-no-nm/+merge/251564
Your team Ubuntu Phablet Team is subscribed to branch lp:phablet-tools.



More information about the Ubuntu-reviews mailing list