[Merge] lp:~peat-new/camera-app/sort-video-resolutions-list into lp:camera-app/staging

Ratchanan Srirattanamet peathot at hotmail.com
Mon May 2 18:31:50 UTC 2016


Ratchanan Srirattanamet has proposed merging lp:~peat-new/camera-app/sort-video-resolutions-list into lp:camera-app/staging.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~peat-new/camera-app/sort-video-resolutions-list/+merge/293557

Sort supported video resolutions list before using it.

Originally, the code assume that the list is in ascending order. But as
some device (e.g. LG L90 Dual) send this list in descending order, and
actually we probably can't rely on it's order anyway, I decided to sort
the list before using it. 

This fixes 2 issues: 
1.) video resolution ordering in UI being inconsistent.
2.) when a device send this list in descending order, and unsupported
resolution is currently selected, it'll select lowest resolution,
which is sometimes actually too low for encoder. This cause recording 
to fail.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~peat-new/camera-app/sort-video-resolutions-list into lp:camera-app/staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 629 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160502/3bba534a/attachment.diff>


More information about the Ubuntu-reviews mailing list