[Merge] lp:~phablet-team/media-hub/fix-1596329 into lp:media-hub

[Jim Hodapp]

Jim Hodapp has proposed merging lp:~phablet-team/media-hub/fix-1596329 into lp:media-hub.

Commit message:
To avoid deadlocking, make sure that we don't ever change the pipeline's state on the streaming thread. It will always be set from the main thread context thanks to g_idle_add(). The deadlock that this fixes was when calling stop() in player_implementation.cpp in the on_end_of_tracklist() handler.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1596329 in Canonical System Image: "media-hub gets easily confused and hangs (needs reboot)"
  https://bugs.launchpad.net/canonical-devices-system-image/+bug/1596329

For more details, see:
https://code.launchpad.net/~phablet-team/media-hub/fix-1596329/+merge/298829

To avoid deadlocking, make sure that we don't ever change the pipeline's state on the streaming thread. It will always be set from the main thread context thanks to g_idle_add(). The deadlock that this fixes was when calling stop() in player_implementation.cpp in the on_end_of_tracklist() handler.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/media-hub/fix-1596329 into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3277 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160630/95880507/attachment-0001.diff>