[Merge] lp:~tiagosh/messaging-app/forward-support into lp:messaging-app

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Looks good, just one comment

Diff comments:

> === modified file 'src/qml/ComposeBar.qml'
> --- src/qml/ComposeBar.qml	2016-05-31 17:12:25 +0000
> +++ src/qml/ComposeBar.qml	2016-06-29 14:21:48 +0000
> @@ -33,11 +33,17 @@
>      property int maxHeight: textEntry.height + units.gu(2)
>      property bool canSend: true
>      property alias text: messageTextArea.text
> -    property bool audioAttached: attachments.count == 1 && attachments.get(0).contentType.toLowerCase().indexOf("audio/") > -1
> +    property bool audioAttached: recorded && attachments.count == 1 && attachments.get(0).contentType.toLowerCase().indexOf("audio/") > -1
> +    property bool recorded: false

Can you just rename the variable so that it is less ambiguous? "recorded" might also be understood as an audio recording operation finished

>      // Audio QML component needs to process the recorded audio to find duration and AudioRecorder seems to erase duration after some events
>      property alias audioRecordedDuration: audioRecordingBar.duration
>      property alias recording: audioRecordingBar.recording
>      property bool oskEnabled: true
> +    onRecordingChanged: {
> +        if (recording) {
> +            recorded = true
> +        }
> +    }
>  
>      signal sendRequested(string text, var attachments)
>  


-- 
https://code.launchpad.net/~tiagosh/messaging-app/forward-support/+merge/298575
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-app.