[Merge] lp:~michael-sheldon/maliit/obey-unity8-focus into lp:~ubuntu-core-dev/maliit/maliit-framework-ubuntu

[Daniel d'Andrada]

Review: Approve code

Patch looks ok to me. Didn't test though.

Nitpicks:

"""
 DBusInputContextConnection::~DBusInputContextConnection()
 {
+    if (mUnityFocus != 0) {
+        delete mUnityFocus;
+    }
 }
"""

This check is unnecessary. You can simply call delete straightaway. It will be a NOOP if the pointer is null.


--------

"""
+++ maliit-framework-0.99.1+git20151118+62bd54b/connection/dbusinputcontextconnection.h
@@ -19,7 +19,9 @@
 
 #include "serverdbusaddress.h"
 
+#include <QDBusArgument>
 #include <QDBusContext>
+#include <QDBusInterface>
 #include <QDBusVariant>

"""

Since I don't that QDBusArgument header being used here, I would move that #include to the cpp file.

To further lighten up this header file, I would also move "#include <QDBusInterface>" to the cpp and have a "class QDBusInterface" forward declaration instead, which is enough for this header.
-- 
https://code.launchpad.net/~michael-sheldon/maliit/obey-unity8-focus/+merge/298312
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/maliit/maliit-framework-ubuntu.