[Merge] lp:~phablet-team/messaging-app/send-typing-notification into lp:messaging-app

[Roberto Mier Escandón ]

Review: Needs Fixing

page text property is always empty while typing a text message. This prevents proper work of typing notifications

Diff comments:

> === modified file 'src/qml/Messages.qml'
> --- src/qml/Messages.qml	2016-06-16 11:19:36 +0000
> +++ src/qml/Messages.qml	2016-06-16 11:19:36 +0000
> @@ -1177,6 +1191,15 @@
>          showContents: !selectionMode && !isSearching
>          maxHeight: messages.height - keyboard.height - screenTop.y
>          text: messages.text
> +        onTextChanged: {

There is a problem in this method. text is always empty while writing a message. It is only fulfilled when pressed button to send the message. This is preventing typing notification being sent properly to the other side. Please check where is the failure

> +            if (text == "") {
> +                messages.chatEntry.setChatState(ChatEntry.ChannelChatStateActive)
> +                selfTypingTimer.stop()
> +                return
> +            }
> +            messages.chatEntry.setChatState(ChatEntry.ChannelChatStateComposing)
> +            selfTypingTimer.start()
> +        }
>          canSend: participants.length > 0 || multiRecipient.recipientCount > 0 || multiRecipient.searchString !== ""
>          oskEnabled: messages.oskEnabled
>  


-- 
https://code.launchpad.net/~phablet-team/messaging-app/send-typing-notification/+merge/296609
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/messaging-app/async_send_message.