[Merge] lp:~thomas-voss/biometryd/add-snapcraft-setup into lp:biometryd

[Scott Sweeny]

Review: Needs Fixing

A couple of suggestions inline to get this building with "snapcraft cleanbuild".

Also, I couldn't get the daemon to run once installed. It came back with:

Jun 24 13:47:59 localhost.localdomain systemd[1]: Started Service for snap application biometryd.biometryd.
Jun 24 13:48:00 localhost.localdomain ubuntu-core-launcher[1365]: terminate called after throwing an instance of 'std::invalid_argument'
Jun 24 13:48:00 localhost.localdomain ubuntu-core-launcher[1365]:   what():  parse error - unexpected end of input
Jun 24 13:48:00 localhost.localdomain systemd[1]: snap.biometryd.biometryd.service: Main process exited, code=killed, status=6/ABRT


Diff comments:

> === added file 'snapcraft.yaml'
> --- snapcraft.yaml	1970-01-01 00:00:00 +0000
> +++ snapcraft.yaml	2016-06-23 20:15:57 +0000
> @@ -0,0 +1,49 @@
> +name: biometryd
> +version: 0.0.1

You can add confinement: devmode to have the snap install in devmode by default until you have all the interfaces worked out.

> +summary: biometryd mediates/multiplexes to biometric devices
> +description: biometryd mediates/multiplexes access to biometric devices
> +  biometryd mediates and multiplexes access to biometric devices present
> +  on the system enabling applications and system components to
> +  leverage them for identification and verification of users.
> +
> +apps:
> +  biometryd:
> +    daemon: simple
> +    command: bin/biometryd run
> +  cli:
> +    command: bin/biometryd
> +
> +parts:
> +  biometryd:
> +    plugin: cmake
> +    configflags:
> +      - -DCMAKE_VERBOSE_MAKEFILE=ON
> +    source: .
> +    build-packages:
> +      - cmake

You need build-essential or similar added to build-packages to build cleanly.

> +      - doxygen
> +      - google-mock
> +      - graphviz
> +      - libapparmor-dev
> +      - libboost-filesystem-dev
> +      - libboost-program-options-dev
> +      - libboost-system-dev
> +      - libboost-test-dev
> +      - libdbus-cpp-dev
> +      - libdbus-1-dev
> +      - libelf-dev
> +      - libgtest-dev
> +      - libprocess-cpp-dev
> +      - libsqlite3-dev
> +      - lsb-release
> +      - pkg-config
> +      - qt5-default
> +      - qtbase5-dev
> +      - qtdeclarative5-dev
> +      - qtdeclarative5-dev-tools
> +      - qtdeclarative5-test-plugin
> +    snap:
> +      - bin/biometryd
> +      - etc/dbus-1/system.d
> +      - lib/
> +      - lib/libbiometryd*


-- 
https://code.launchpad.net/~thomas-voss/biometryd/add-snapcraft-setup/+merge/298255
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/biometryd/add-snapcraft-setup into lp:biometryd.