[Merge] lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs

[Louis Zuckerman]

Louis Zuckerman has proposed merging lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1565985 in cloud-images: "vagrant vb ubuntu/xenial64 cannot mount synced folders"
  https://bugs.launchpad.net/cloud-images/+bug/1565985

For more details, see:
https://code.launchpad.net/~semiosis/livecd-rootfs/fix-for-1565985/+merge/298305

Several problems with the official ubuntu vagrant boxes for Xenial:

- Standard packages were missing (virtualbox-guest stuff, config management stuff)
- Box name was statically assigned, limiting to only one instance per host
- Default synced folder was disabled

This change fixes all of the above issues.

Also cleaned up some inconsistent indentation.

Last of all, had to change the shebang to not use -u.  This is because clean_loops (from functions) gets called twice and the second time (by trap) has unset variables so the build would die.

As a side note, a solution to allow clean_loops to run twice under bash -u would be to use ${var_name-} instead of ${var_name} in the two variable test lines, but that was out of scope for my issues.  Just FYI.

Thank you!
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4943 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160624/692eac1a/attachment.diff>