[Merge] lp:~artmello/ubuntu-push/ubuntu-push-settings_notifications into lp:ubuntu-push/automatic

[Samuele Pedroni]

overall looks good, but not a GSettings or anymore click hook expert,

one question below

Diff comments:

> 
> === added file 'scripts/click-hook-wrapper'
> --- scripts/click-hook-wrapper	1970-01-01 00:00:00 +0000
> +++ scripts/click-hook-wrapper	2016-06-17 14:36:29 +0000
> @@ -0,0 +1,13 @@
> +#!/bin/sh  
> +                                                                   
> +# PackageKit clears all environment variables, so we get the UID and then read
> +# in $DBUS_SESSION_BUS_ADDRESS from /run/user/$UID/dbus-session    
> +
> +USERID=`id -u`                                                     
> +
> +if test -z "$DBUS_SESSION_BUS_ADDRESS" ; then                      
> +  [ -e /run/user/$USERID/dbus-session ] && . /run/user/$USERID/dbus-session 

I don't remember, I suppose click hooks are never run outside a user session?

> +  [ -n "$DBUS_SESSION_BUS_ADDRESS" ] && export DBUS_SESSION_BUS_ADDRESS 
> +fi
> +  
> +/usr/lib/ubuntu-push-client/click-hook


-- 
https://code.launchpad.net/~artmello/ubuntu-push/ubuntu-push-settings_notifications/+merge/296335
Your team Ubuntu Push Hackers is requested to review the proposed merge of lp:~artmello/ubuntu-push/ubuntu-push-settings_notifications into lp:ubuntu-push/automatic.