[Merge] lp:~santoshbit2007/webbrowser-app/webcontainer_shortcut_fix into lp:webbrowser-app
Alexandre Abreu
alexandre.abreu at canonical.com
Fri Jun 17 21:01:28 UTC 2016
Review: Needs Fixing
I found the reason why the test was failing for me:
https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1593877
I think that we should follow one or the other convention but not mix StandardKey.Refresh and e.g. F5
Diff comments:
>
> === modified file 'tests/autopilot/webapp_container/tests/test_chrome.py'
> --- tests/autopilot/webapp_container/tests/test_chrome.py 2015-03-25 18:00:43 +0000
> +++ tests/autopilot/webapp_container/tests/test_chrome.py 2016-06-16 05:44:56 +0000
> @@ -27,6 +28,7 @@
> self.assertIsNotNone(self.get_webcontainer_proxy())
> webview = self.get_webcontainer_webview()
> self.assertThat(webview.chromeless, Equals(True))
> + self.keyboard = input.Keyboard.create()
please remove this, this is not needed,
>
> def test_enable_chrome_back_forward(self):
> args = ['--enable-back-forward']
--
https://code.launchpad.net/~santoshbit2007/webbrowser-app/webcontainer_shortcut_fix/+merge/297355
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list