[Merge] lp:~larryprice/ciborium/go1.6-port into lp:ciborium

Larry Price larry.price at canonical.com
Fri Jun 17 18:53:37 UTC 2016


Larry Price has proposed merging lp:~larryprice/ciborium/go1.6-port into lp:ciborium.

Commit message:
Fix crash on startup hopefully related to bug #1592421.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1592421 in ciborium (Ubuntu): "ciborium crashes on rc-proposed"
  https://bugs.launchpad.net/ubuntu/+source/ciborium/+bug/1592421

For more details, see:
https://code.launchpad.net/~larryprice/ciborium/go1.6-port/+merge/297801

Fix crash on startup hopefully related to bug #1592421.

As far as I can tell, this crash was happening due to a new cgo error that only happens in go1.6. My assumption is that the binary was compiled using go1.6. go-qml has related bug https://github.com/go-qml/qml/issues/170. I merged https://github.com/SjB/qml/tree/go1.6-port into the local qml.v1 directory to swipe the fixes for this issue. Hopefully eventually this will become a PR and get officially merged into go-qml.v1.

I also adjusted the syntax being used to run the application with go-qml to get better error reporting. With the old method, I saw a simple stacktrace with no useful information. With the new method, I was able to see: `panic: runtime error: cgo argument has Go pointer to Go pointer` which led me to this particular solution.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~larryprice/ciborium/go1.6-port into lp:ciborium.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 31071 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160617/610ba420/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list