[Merge] lp:~abreu-alexandre/webbrowser-app/front-camera-as-default-capture into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

In src/app/BrowserView.qml, you want i18n.dtr("oxide-qt", "Front") to pick up the translated string from oxide.

Is there really a need for a currentWebviewContext property? Can’t you simply refer to SharedWebContext.sharedContext everywhere instead? What’s the point of having a null currentWebviewContext in WebApp.qml if there is no webview yet? The context being a singleton, its lifetime should be independent from that of the webviews using it, no?

In BrowserView.qml, __internal doesn’t need to be a property, it can simply be a child of the FocusScope.

Can 'cameraIdVideoCaptureDefault' be renamed 'defaultVideoCaptureDeviceId'?
Can 'cameraPositionVideoCaptureDefault' be renamed 'defaultVideoCaptureDevicePosition'?

In BrowserView.qml, instead of connecting to 'changed' signals in an imperative manner, could you do it in a declarative way (using a Connections element)?
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/front-camera-as-default-capture/+merge/291527
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.