[Merge] lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app

Michael Terry michael.terry at canonical.com
Wed Jun 15 00:05:38 UTC 2016


The proposal to merge lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app has been updated.

Description changed to:

See bug 1581047 for full rationale.

Here is a list of potentially noticeable changes:

- Orange buttons are now green.
- Some less important buttons that were orange are now neutral grey: DisableFlightModeDialog cancel, NoDefaultSIMCardDialog no and later, NotificationDialog close, and SetDefaultSIMCardDialog no.
- Call button went from a dark green to theme green.
- Hangup button no longer changes to half-opacity orange when pressed.  Instead it simply changes to half-opacity theme red.  Didn't seem necessary to also change color on top of opacity when pressing.
- KeypadEntry cursor went from orange to blue, the new theme color for text cursors.
- One sublabel in KeypadButton got bumped to tertiaryText instead of secondaryText.
- Unrelated to color, but I was right there, so...  SimLockedDialog's Ok button is now spelled OK.  (OK and Okay are words, Ok is not.)

And some less noticeable changes:

- Simply switching hard-coded names to theme equivalents (like darkGrey to backgroundSecondaryColor; same color, new name)
- Small changes like off-brand "red" to theme red

For more details, see:
https://code.launchpad.net/~mterry/dialer-app/no-ubuntu-colors/+merge/297412
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app.



More information about the Ubuntu-reviews mailing list