[Merge] lp:~abreu-alexandre/webbrowser-app/container-print-help-when-no-appid into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Jun 14 08:04:02 UTC 2016


BrowserApplication::isPrintHelpLaunch() doesn’t need to take an argument, it could be made non-static and read m_arguments.

But there’s a cleaner approach I think: the check for -h or --help and the call to printUsage() could be done in the constructor (BrowserApplication::BrowserApplication()), and this would set a flag (maybe called "m_shouldExitEarly", or something like that) that the main function would test before calling initialize().

On a slightly related note, in WebappContainer::initialize() the call to earlyEnvironment() should go after the check for the appId.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/container-print-help-when-no-appid/+merge/297220
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/container-print-help-when-no-appid into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list