[Merge] lp:~phablet-team/messaging-framework/rename_interfaces into lp:messaging-framework

[Roberto Mier Escandón ]

Review: Needs Fixing

Just a comment

Diff comments:

> === modified file 'include/messaging/qt/tp/text_channel.h'
> --- include/messaging/qt/tp/text_channel.h	2016-06-13 03:19:55 +0000
> +++ include/messaging/qt/tp/text_channel.h	2016-06-13 08:34:23 +0000
> @@ -203,13 +203,13 @@
>      void plug_interfaces_once();
>      void plug_interface_if_available(const Tp::AbstractChannelInterfacePtr &interface);
>  
> -    Tp::BaseChannelTextTypePtr bctt;
> -    Tp::BaseChannelMessagesInterfacePtr bcmi;
> -    Tp::BaseChannelRoomInterfacePtr bcri;
> -    Tp::BaseChannelRoomConfigInterfacePtr bcrci;
> -    Tp::BaseChannelGroupInterfacePtr bcgi;
> +    Tp::BaseChannelTextTypePtr text_type_interface;
> +    Tp::BaseChannelMessagesInterfacePtr messages_interface;
> +    Tp::BaseChannelRoomInterfacePtr room_interface;
> +    Tp::BaseChannelRoomConfigInterfacePtr room_config_interface;
> +    Tp::BaseChannelGroupInterfacePtr group_interface;
>      Tp::BaseChannelChatStateInterfacePtr chat_state_iface;

Actually, we could change all the suffix to be iface or interface, whatever it works for you

> -    interfaces::BaseChannelDestroyableInterfacePtr bcdi;
> +    interfaces::BaseChannelDestroyableInterfacePtr destroyable_interface;
>  
>      // NOTE(rmescandon): this is a temporal member in the class not needed from Telepathy Qt >= 0.9.7.0 which
>      // includes Tp::BaseChannel::connection() method to obtain it whenever is needed.


-- 
https://code.launchpad.net/~phablet-team/messaging-framework/rename_interfaces/+merge/297157
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-framework.