[Merge] lp:~malizor/update-manager/ppa-changelogs into lp:update-manager

Nicolas Delvaux contact at nicolas-delvaux.org
Fri Jun 10 23:11:28 UTC 2016


Nicolas Delvaux has proposed merging lp:~malizor/update-manager/ppa-changelogs into lp:update-manager.

Commit message:
Retrieve Changelogs from PPA sources if python3-launchpadlib is installed.

This uses the approach suggested by Colin Watson in LP: #253119.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~malizor/update-manager/ppa-changelogs/+merge/297119

Retrieve Changelogs from PPA sources if python3-launchpadlib is installed.

This uses the approach suggested by Colin Watson in LP: #253119.

I don't think it would be reasonable to add python3-launchpadlib to the hard dependency list: it would pull it and its dependencies into the default install, which is an additional 3269kB on Xenial.

Therefore, I only set python3-launchpadlib as a suggest dependency and I made the whole feature optional: if launchpadlib is not installed, nothing change except for a new warning in logs to suggest to install the library.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~malizor/update-manager/ppa-changelogs into lp:update-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5163 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160610/c6a204cc/attachment.diff>


More information about the Ubuntu-reviews mailing list