[Merge] lp:~mterry/ubuntu-keyboard/report-max-height into lp:ubuntu-keyboard
Michael Terry
michael.terry at canonical.com
Fri Jun 3 15:12:05 UTC 2016
Heyo! Here's take 2. I took the ratio logic from Keyboard.qml and moved it down a layer into keyboardgeometry.cpp.
However... it still doesn't work. :)
Now my problem is that I relied on the existing calls to KeyboardGeometry::setOrientation to actually be functional. But it doesn't seem like it's every updated.
inputmethod.cpp does a lot of d->setLayoutOrientation() calls. But that only really gets updated when maliit calls handleAppOrientationChanged().
But at this point I'm out of my depth. But basically, the orientation never updated while I was rotating my phone. Which meant that the keyboard geometry never got to adjust its canvas ratio.
Pointers? Is the approach reasonable besides this bug?
--
https://code.launchpad.net/~mterry/ubuntu-keyboard/report-max-height/+merge/294585
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/ubuntu-keyboard/report-max-height into lp:ubuntu-keyboard.
More information about the Ubuntu-reviews
mailing list