[Merge] lp:~artmello/ubuntu-push/ubuntu-push-settings_notifications into lp:ubuntu-push

[Samuele Pedroni]

question

Diff comments:

> 
> === modified file 'scripts/click-hook'
> --- scripts/click-hook	2015-04-01 14:46:20 +0000
> +++ scripts/click-hook	2016-05-31 00:30:36 +0000
> @@ -100,6 +185,13 @@
>          cleanup_settings()
>      except Exception:
>          clean_settings_fail = True
> +
> +    # Do not fail if populate fails
> +    try:
> +        populate_notifications_settings(hooks_path)
> +    except Exception:
> +        pass

the other things we do here set a flag and use it in the return? any reasons or not to do it here? (I don't remember how the hook machinary deals with that so not sure myself)

> +
>      return int(collect_fail or clean_settings_fail)
>  
>  


-- 
https://code.launchpad.net/~artmello/ubuntu-push/ubuntu-push-settings_notifications/+merge/295706
Your team Ubuntu Push Hackers is requested to review the proposed merge of lp:~artmello/ubuntu-push/ubuntu-push-settings_notifications into lp:ubuntu-push.