[Merge] lp:~abreu-alexandre/webbrowser-app/delay-bind-embeddedUiComponentParent into lp:webbrowser-app

[Alberto Mardegan]

Review: Needs Information

One inline comment :-)

Diff comments:

> === modified file 'src/app/webcontainer/WebApp.qml'
> --- src/app/webcontainer/WebApp.qml	2016-06-20 15:07:26 +0000
> +++ src/app/webcontainer/WebApp.qml	2016-06-27 13:28:57 +0000
> @@ -273,10 +273,17 @@
>          id: unityWebapps
>          name: webappName
>          bindee: containerWebView.currentWebview
> -        embeddedUiComponentParent: webapp
>          actionsContext: actionManager.globalContext
>          model: UnityWebApps.UnityWebappsAppModel { searchPath: webappModelSearchPath }
>          injectExtraUbuntuApis: runningLocalApplication
>          injectExtraContentShareCapabilities: !runningLocalApplication
> +
> +        Component.onCompleted: {
> +            // Delay bind the property to add a bit of backward compatibility with
> +            // other unity-webapps-qml modules
> +            if (unityWebapps.embeddedUiComponentParent) {

Did you mean !unityWebapps.embeddedUiComponentParent?

The embeddedUiComponentParent proparty is initialized to null in UnityWebApps, and never written to, so I guess this condition will always be false...

> +                unityWebapps.embeddedUiComponentParent = webapp
> +            }
> +        }
>      }
>  }


-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/delay-bind-embeddedUiComponentParent/+merge/298422
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.