[Merge] lp:~ken-vandine/content-hub/pasteboard into lp:content-hub

Ken VanDine ken.vandine at canonical.com
Tue Jul 26 21:05:15 UTC 2016


> > Made some modifications here:
> > http://bazaar.launchpad.net/~dandrader/content-hub/pasteboard/revision/285
> >
> > - Fix unnecessary round trip and memory leak when fetching a Paste from the
> > service
> > - Simplify D-Bus interface and traffic using ay instead of av
> > - Create separate sync and async versions of createPaste
> 
> Oh, and added async versions for latestPaste() and pasteById() as well.

These changes are great!  Only comment I have is I prefer making createPaste async and making the sync version something like createPasteSync.  Makes it feel like the preferred function is the async one.  But that's not a must for me, it's just more like I'm used to doing with gobject style code.  What do you think is more common for Qt?
-- 
https://code.launchpad.net/~ken-vandine/content-hub/pasteboard/+merge/296352
Your team Ubuntu Phablet Team is subscribed to branch lp:content-hub.



More information about the Ubuntu-reviews mailing list