[Merge] ~awe/network-manager/+git/ubuntu:touch-vivid-ota13 into ~network-manager/network-manager/+git/ubuntu:touch-vivid

Tony Espy espy at canonical.com
Tue Jul 26 14:33:25 UTC 2016


Tony Espy has proposed merging ~awe/network-manager/+git/ubuntu:touch-vivid-ota13 into ~network-manager/network-manager/+git/ubuntu:touch-vivid.

Commit message:
    Add d/p/secret-agent-fix-get-secrets-timeout.patch
    
    Cherry pick upstream patch which restores the secret-agent
    GetSecrets DBus timeout to 2m.  This was removed during the
    move from dbus-glib to gdbus, which resulted in the timeout
    being lowered to the default 25s, which is too short for a
    user to enter most lengthy passphrases (LP: #1588126).


Requested reviews:
  Network-manager (network-manager)

For more details, see:
https://code.launchpad.net/~awe/network-manager/+git/ubuntu/+merge/301177

This change is a cherry picked upstream patch which restores the secret-agent GetSecrets DBus timeout to 2m.  This was removed during the move from dbus-glib to gdbus, which resulted in the timeout being lowered to the default 25s, which is too short for a user to enter most lengthy passphrases (LP: #1588126).

Testing this patch requires a WPA access point with a long passphrase ( 20-22+ characters in length ).  Without this patch, it will be almost impossible to manually enter such a long passphrase before NM times out, and subsequently ignores the submitted passphrase.

-- 
Your team Network-manager is requested to review the proposed merge of ~awe/network-manager/+git/ubuntu:touch-vivid-ota13 into ~network-manager/network-manager/+git/ubuntu:touch-vivid.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2725 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160726/43373f72/attachment.diff>


More information about the Ubuntu-reviews mailing list