[Merge] lp:~awe/ofono/midori-switch-4g-update into lp:~phablet-team/ofono/ubuntu

Tony Espy espy at canonical.com
Tue Jul 19 15:20:49 UTC 2016


Tony Espy has proposed merging lp:~awe/ofono/midori-switch-4g-update into lp:~phablet-team/ofono/ubuntu.

Commit message:
  * Add automatic SIM slot capability switching for midori:
   * include: gprs: remove set ia
   * gprs: remove calls to set_ia_apn
   * gril: fix memory leak, print radio_caps event
   * ril: create radio settings when onlining
   * rilmodem: gprs: remove set_ia_apn
   * rilmodem: radio-settings: enable switch slots caps
   * qcommsimmodem: remote set_ia_apn
   * qcommsimmodem: adapt to radio settings changes
   * mtkmodem: adapt to radio settings changes
   * mtkmodem: remove set_ia_apn
   * mtk2modem: remove set_ia_apn


Requested reviews:
  Scott Sweeny (ssweeny)

For more details, see:
https://code.launchpad.net/~awe/ofono/midori-switch-4g-update/+merge/300483

This change adds support for dynamic switching of radio capabilities for dual-standby modems which use the rilmodem driver ( eg. midori ).

Instead of having to explicitly call a DBus method to switch which SIM slot has the ability use 3g or 4g, now the client just uses the standard method of changing the network technology preference.  If this new setting requires the slot capabilities to be swapped, rilmodem will do this automatically on behalf of the client.

This change re-works some of the code necessary for LTE support, and as such, we should ensure that LTE still works properly on the MX4 ( EU / China only ).


-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 32608 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160719/809bb353/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list