[Merge] lp:~jonas-drange/ubuntu-push/disable-logger-test-on-gccgo into lp:ubuntu-push

Jonas G. Drange jonas.drange at canonical.com
Mon Jul 18 10:49:05 UTC 2016


Jonas G. Drange has proposed merging lp:~jonas-drange/ubuntu-push/disable-logger-test-on-gccgo into lp:ubuntu-push.

Commit message:
disable logger tests that expect log.Lshortfile on ppc/arm 64

Requested reviews:
  system-apps-ci-bot (system-apps-ci-bot): continuous-integration
  Ubuntu Push Hackers (ubuntu-push-hackers)

For more details, see:
https://code.launchpad.net/~jonas-drange/ubuntu-push/disable-logger-test-on-gccgo/+merge/300307

Seems gccgo produces the wrong output for log.lshortfile. Since this issue [1] is wontfix and we're asked to upgrade, let's skip the test if it produces this erroneous (?) output. 

Regexp test case:
https://play.golang.org/p/OL-Z-jaWBf

[1] https://github.com/golang/go/issues/16406
-- 
Your team Ubuntu Push Hackers is requested to review the proposed merge of lp:~jonas-drange/ubuntu-push/disable-logger-test-on-gccgo into lp:ubuntu-push.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1525 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160718/2a4931d6/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list