[Merge] lp:~abreu-alexandre/trust-store/cleaner into lp:trust-store

Thomas Voß thomas.voss at canonical.com
Mon Jul 11 06:26:54 UTC 2016


Review: Approve

LGTM.

Diff comments:

> === modified file 'include/core/trust/store.h'
> --- include/core/trust/store.h	2014-07-23 13:55:07 +0000
> +++ include/core/trust/store.h	2016-07-08 19:09:36 +0000
> @@ -203,6 +203,15 @@
>      };
>  };
>  
> +class PurgeableStore : public trust::Store
> +{
> +public:
> +    /** @brief purge the store from any reference to the given application
> +     * When this function returns true, the request has been persisted by the implementation.

copy'n'paste leftover, feel free to ignore the niggle.

> +     */
> +    virtual void purge(const std::string& id) = 0;
> +};
> +  
>  /**
>    * @brief Creates an instance for the default store implementation.
>    * @throw Error::ServiceNameMustNotBeEmpty.


-- 
https://code.launchpad.net/~abreu-alexandre/trust-store/cleaner/+merge/299460
Your team Ubuntu Phablet Team is subscribed to branch lp:trust-store.



More information about the Ubuntu-reviews mailing list